Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Down integrate Google3 changes to Github #6752

Merged
merged 4 commits into from Oct 24, 2019
Merged

Down integrate Google3 changes to Github #6752

merged 4 commits into from Oct 24, 2019

Conversation

rafi-kamal
Copy link
Contributor

No description provided.

@rafi-kamal
Copy link
Contributor Author

Fixes #6718

@rafi-kamal
Copy link
Contributor Author

@TeBoring can you please look at the conformance test failures?
Also @TeBoring @anandolee looks like the Java tests are failing with the following error:

[ERROR]   The project com.google.protobuf:protobuf-java-util:3.11.0-rc-0 (/tmp/protobuf/protobuf/java/util/pom.xml) has 2 errors
[ERROR]     Non-resolvable import POM: Could not find artifact com.google.protobuf:protobuf-bom:pom:3.11.0-rc-0 in central (https://repo.maven.apache.org/maven2) @ com.google.protobuf:protobuf-parent:3.11.0-rc-0, /tmp/protobuf/protobuf/java/pom.xml, line 68, column 19 -> [Help 2]

Let's discuss this with Tomo.

@TeBoring
Copy link
Contributor

@suztomo seems the pom issue happens again. Could you help take a look?

@suztomo
Copy link
Contributor

suztomo commented Oct 11, 2019

I’m OOO until Oct 17th. I will check the detail after that. I see Linkage Monitor presubmit succeeded:

379A855C-01D7-408C-B80C-59DCC0D3BA2C

@rafi-kamal rafi-kamal mentioned this pull request Oct 16, 2019
Closed
@suztomo suztomo mentioned this pull request Oct 22, 2019
Merged
@rafi-kamal
Copy link
Contributor Author

#6786 should fix the javalite build failure.

anandolee
anandolee approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@anandolee anandolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for python

@rafi-kamal rafi-kamal merged commit 342a2d6 into protocolbuffers:master Oct 24, 2019
bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
@rafi-kamal
Merge pull request protocolbuffers#6752 from rafi-kamal/201910111201
9d536c7 
Down integrate Google3 changes to Github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acozzette acozzette acozzette approved these changes

@anandolee anandolee anandolee approved these changes

@TeBoring TeBoring Awaiting requested review from TeBoring

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rafi-kamal @TeBoring @suztomo @acozzette @anandolee @googlebot @protobuf-kokoro