Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-java: Fix broken javadoc generation #6802

Merged
merged 1 commit into from Oct 28, 2019
Merged

protoc-java: Fix broken javadoc generation #6802

merged 1 commit into from Oct 28, 2019

Conversation

ST-DDT
Copy link
Contributor

@ST-DDT ST-DDT commented Oct 25, 2019

protoc-3.10.0 generates broken javadocs for repeated enum values:

/**
 * <pre>
 * A list of types.
 * </pre>
 * <code>repeated .foo.bar.ItemType types = 1;</code>
 * @param value The types to add.
 */
public int getTypesCount() {
    return types_.size();
}

which causes an error during javadoc generation.

This PR fixes that issue by using the correct parameter.
The error was accidentally added by me in #6231

Maybe this fix could be added to a 3.10.1 release.

@acozzette acozzette self-assigned this Oct 28, 2019
@acozzette acozzette merged commit 4252b7a into protocolbuffers:master Oct 28, 2019
@acozzette
Copy link
Member

Thanks, @ST-DDT.

@ST-DDT ST-DDT deleted the fix-javadoc-issue branch October 29, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants