-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby: Create a git version file with rake as part of the build process. #6841
Ruby: Create a git version file with rake as part of the build process. #6841
Conversation
This helps debuggability for dev builds, by allowing us to print the git version the gem was built against.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@penelopezone Thank you for the pull request and sorry for taking so long to review this. Our main concern is that we would expect the version number to usually be sufficient for debugging--can you say more about why you need the Git commit? Another thing is that we heard in #9219 that if you use bundler with the git source option it will not invoke the Rakefile at all, which means that it helps if we can avoid generating any required files through rake. |
I opened this pull request when I worked at google and don't recall the context, apologies (you can reach out to mcloonan@ who might know) |
Oh ok, no problem! Let me just go ahead and close this then. |
This helps debuggability for dev builds, by allowing us to print the git
version the gem was built against.