Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArgumentException in C# when any proto file with extension is imported multiple times #6954

Closed
wants to merge 2 commits into from
Closed

Fix ArgumentException in C# when any proto file with extension is imported multiple times #6954

wants to merge 2 commits into from

Commits on Apr 14, 2020

  1. Fix 'ArgumentException: An item with the same key has already been ad… 

    …ded. Key: Google.Protobuf.ObjectIntPair' when using Descriptor with proto file with any proto file with extensions is imported multiple times(imported directly or imported by dependencies proto files).

Distinct all depended FileDescriptor for extensions
    @owent
    owent committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    95e4c28 View commit details
    Browse the repository at this point in the history

  2. Rebase on protocolbuffers#6938. Remove redundant unit test and just k… 

    …eep the code to remove repeated depended files.
    @owent
    owent committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    0a09952 View commit details
    Browse the repository at this point in the history