Add a proto_lang_toolchain for javalite (3.11.x backport) #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a proto_lang_toolchain for javalite * fix toolchain. Swap javalite example to master repo
|
The 3.11.1 release process has already started (the protoc for 3.11.1 has already been uploaded to Maven), I'm happy to merge the PR after 3.11.1 release is finished (today/tomorrow), but we don't have a timeline for the next release yet. |
rafi-kamal
approved these changes
Dec 3, 2019
|
Just being on the release branch is enough. It is easy to point to a commit from Bazel, but pointing to something on master (like #6882) makes it unclear if there will be compatibility issues. |
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Dec 4, 2019
Bazel was stuck on the javalite branch of protobuf because the master branch was lacking the toolchain necessary for javalite. The fix was backported to 3.11 in protocolbuffers/protobuf#6976
ejona86
added a commit
to grpc/grpc-java
that referenced
this pull request
Dec 4, 2019
Bazel was stuck on the javalite branch of protobuf because the master branch was lacking the toolchain necessary for javalite. The fix was backported to 3.11 in protocolbuffers/protobuf#6976
ericgribkoff
pushed a commit
to ericgribkoff/grpc-java
that referenced
this pull request
Dec 6, 2019
Bazel was stuck on the javalite branch of protobuf because the master branch was lacking the toolchain necessary for javalite. The fix was backported to 3.11 in protocolbuffers/protobuf#6976
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
Bazel was stuck on the javalite branch of protobuf because the master branch was lacking the toolchain necessary for javalite. The fix was backported to 3.11 in protocolbuffers/protobuf#6976
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that javalite can be used from Bazel. Related discussion: #6867
This is a backport of #6882