Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile errors on case-sensitive APFS #7007

Closed
wants to merge 1 commit into from

Conversation

ledyba-z
Copy link

Hi. I couldn't add protobuf to iOS App. using CocoaPods with compile errors:

スクリーンショット 2019-12-11 11 43 43

I figured out Any.pbobjc.h is located on Protobuf, not protobuf, and also, my disk is formatted as case-sensitive APFS. So that the objc compiler cannot find the header.

Here is my podfile:

# Uncomment this line to define a global platform for your project
platform :ios, '11.0'
use_modular_headers!
inhibit_all_warnings!
# use_frameworks!

target '*****' do
    ....
    pod 'Protobuf'
    ....
end

This patch may also fixes: invertase/react-native-firebase#2780

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ledyba-z
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ledyba-z
Copy link
Author

ledyba-z commented Dec 11, 2019

Oh, I found these closed pull requests...

Override CocoaPods module to lowercase by paulb777 · Pull Request #6464 · protocolbuffers/protobuf
#6464

Fix CocoaPods case warnings by paulb777 · Pull Request #6190 · protocolbuffers/protobuf
#6190

What should I do for this compile error?

I know that this patch solves my compile errors, but is this the correct way?
To be honest, I am not familiar with cocoapods/iOS/ObjC.


I'm using Xcode Version 11.3 (11C29),

other software versions:

% cat .ruby-version
2.6.3
% bundler exec pod --version
1.8.4

@thomasvl
Copy link
Contributor

As you see from those other issues, there isn't a clear "fix" at the moment.

This PR would cause warnings for some of the other setups because the tree of directories/links created by cocoapods isn't consistent (some times it is the package name, some times it is the module name).

So short of doing what is suggested in some of those where we abandon the Protobuf pod name for protobuf and thus require everyone to migrate, there doesn't seem to be a real solution (and during that migration folks could run into double definitions when they get both).

@thomasvl thomasvl closed this Dec 11, 2019
@thomasvl
Copy link
Contributor

ps - #6803 is the currently open issue for tracking the problem

@ledyba-z
Copy link
Author

Thank you reviewing and telling me the current status!
OK, I will track that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf erro after upgrade 'protobuf/Any.pbobjc.h' file not found!
3 participants