Blacklist .proto source files if Bazel allows us to #7065
Conversation
This is a partial revert of protocolbuffers@7b28278 to unblock, e.g., grpc/grpc#21590 or envoyproxy/envoy-mobile#617 until Bazel is fixed. Note: this is a forward-compatible change that automatically switches to the behavior intended by protocolbuffers@7b28278 when a compatible Bazel is released without requiring users to upgrade Protobuf. We will revert this change when Bazel is fixed.
BUILD
Outdated
| @@ -986,9 +986,11 @@ cc_library( | |||
| ], | |||
| ) | |||
|
|
|||
| reject_blacklisted_files = not hasattr(proto_common, "proto_lang_toolchain_rejects_files_do_not_use_or_we_will_break_you_without_mercy"), | |||
There was a problem hiding this comment.
@lberki @cushon @hlopko I'd love to get your lgtm on this "feature flag" so we don't have to synchronize flipping a future --incompatible_blacklisted_protos_requires_proto_info (or whatever that flag will be called) with protobuf releases. See bazelbuild/bazel#10493 and bazelbuild/bazel#10484 for context.
There was a problem hiding this comment.
Do I understand correctly that the sole reason for this change is http://github.com/bazelbuild/bazel/issues/10484 and thus if that is fixed, this change and the flag becomes unnecessary?
Yannic
changed the title
|
@rafi-kamal Sorry, I did move some parts into variables after testing it which left trailing |
|
FYI the Linux Ruby Release and MacOS Ruby 2.3 tests are broken for a while, so the failures are likely not related. |
|
@rafi-kamal Thanks! The failures are indeed unrelated, we're only touching Bazel I think we can merge (& cherry-pick onto |
* Blacklist .proto source files is Bazel allows us to This is a partial revert of 7b28278 to unblock, e.g., grpc/grpc#21590 or envoyproxy/envoy-mobile#617 until Bazel is fixed. Note: this is a forward-compatible change that automatically switches to the behavior intended by 7b28278 when a compatible Bazel is released without requiring users to upgrade Protobuf. We will revert this change when Bazel is fixed. * Remove trailing , * Update BUILD
* Blacklist .proto source files is Bazel allows us to This is a partial revert of 7b28278 to unblock, e.g., grpc/grpc#21590 or envoyproxy/envoy-mobile#617 until Bazel is fixed. Note: this is a forward-compatible change that automatically switches to the behavior intended by 7b28278 when a compatible Bazel is released without requiring users to upgrade Protobuf. We will revert this change when Bazel is fixed. * Remove trailing , * Update BUILD
This is a partial revert of 7b28278 to unblock, e.g., grpc/grpc#21590 or envoyproxy/envoy-mobile#617 until Bazel is fixed.
Note: this is a forward-compatible change that automatically switches to the behavior intended by 7b28278 when a compatible Bazel is released without requiring users to upgrade Protobuf. We will revert this change when Bazel is fixed.