Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for wrappers with a zero value #7195

Merged
merged 4 commits into from Feb 11, 2020
Merged

Fix for wrappers with a zero value #7195

merged 4 commits into from Feb 11, 2020

Commits on Dec 19, 2019

  1. Add failing tests for issues with wrapped values where the value is t… 

    …he default
    @djquan
    djquan committed Dec 19, 2019
    Copy the full SHA
    57d47b5 View commit details
    Browse the repository at this point in the history

  2. Add test for wrapped values without a value set

    @djquan
    djquan committed Dec 19, 2019
    Copy the full SHA
    1da3ddd View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Merge branch 'master' into failing_test_for_wrapped

    @haberman
    haberman committed Feb 10, 2020
    Copy the full SHA
    dc0358d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Bugfix for wrapper types with default values. 

    The previous optimizations for wrapper types had a bug that prevented
wrappers from registering as "present" if the "value" field was not
present on the wire.

In practice the "value" field will not be serialized when it is zero,
according to proto3 semantics, but due to the optimization this
prevented it from creating a new object to represent the presence of the
field.

The fix is to ensure that if the wrapper message is present on the wire,
we always initialize its value to zero.
    @haberman
    haberman committed Feb 11, 2020
    Copy the full SHA
    aa62233 View commit details
    Browse the repository at this point in the history