Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Has/Clear members for C# message fields in proto2 #7429

Merged
merged 3 commits into from May 1, 2020
Merged

Remove Has/Clear members for C# message fields in proto2 #7429

merged 3 commits into from May 1, 2020

Commits on Apr 27, 2020

  1. Don't generate Has/Clear members for proto2 message fields. 

    This is a breaking change in terms of proto2 code generation: users who were previously using these members will have to change to null checks for message fields.
After toying with removing Has/Clear for proto2 oneof fields, I've left them alone in this commit, for consistency with other languages. The inconsistency between proto2 and proto3 won't come up here, because proto3 oneof fields can never be explicitly optional.

Fixes protocolbuffers#7395.
    @jskeet
    jskeet committed Apr 27, 2020
    Copy the full SHA
    39efb4b View commit details
    Browse the repository at this point in the history

  2. Regenerate C# code based on the previous commit 

    (This removes the Has/Clear members for message types in proto2.)
    @jskeet
    jskeet committed Apr 27, 2020
    Copy the full SHA
    fb70c01 View commit details
    Browse the repository at this point in the history

  3. Fix to C# support library code 

    (This was the only use of a HasXyz property for a message type.)
    @jskeet
    jskeet committed Apr 27, 2020
    Copy the full SHA
    b56a8de View commit details
    Browse the repository at this point in the history