Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Mark GetOption API as obsolete and expose the "GetOptions()" method on descriptors instead #7434

Merged
merged 8 commits into from May 11, 2020
Merged

C#: Mark GetOption API as obsolete and expose the "GetOptions()" method on descriptors instead #7434

merged 8 commits into from May 11, 2020

Commits on Apr 28, 2020

  1. expose Options property on descriptors

    @jtattermusch
    jtattermusch committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    944055a View commit details
    Browse the repository at this point in the history

  2. adjust CustomOptionsTest.cs

    @jtattermusch
    jtattermusch committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    9720ae4 View commit details
    Browse the repository at this point in the history

  3. add a few more tests

    @jtattermusch
    jtattermusch committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    f4ff220 View commit details
    Browse the repository at this point in the history

  4. add back GetOption methods, but mark them as obsolete

    @jtattermusch
    jtattermusch committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    062c2dc View commit details
    Browse the repository at this point in the history

  5. add back GetOption tests

    @jtattermusch
    jtattermusch committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    402ce8b View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. remove unnecessary cast

    @jtattermusch
    jtattermusch committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    673245f View commit details
    Browse the repository at this point in the history

  2. clarify docs

    @jtattermusch
    jtattermusch committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    ff999c9 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. address review comments

    @jtattermusch
    jtattermusch committed May 6, 2020
    Configuration menu
    Copy the full SHA
    0688883 View commit details
    Browse the repository at this point in the history