New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# write benchmark improvements #7658
Merged
jtattermusch
merged 2 commits into
protocolbuffers:master
from
jtattermusch:csharp_benchmark_improvements
Jul 1, 2020
Merged
C# write benchmark improvements #7658
jtattermusch
merged 2 commits into
protocolbuffers:master
from
jtattermusch:csharp_benchmark_improvements
Jul 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@JamesNK can you please review? |
jtattermusch
force-pushed
the
csharp_benchmark_improvements
branch
from
June 29, 2020 07:59
6917092
to
c582db8
Compare
Comparison for using
|
the CI doesn't have a new-enough version of the SDK (which is something that would need to be fixed first).
|
JamesNK
approved these changes
Jun 29, 2020
Opps, I saw 3.x in global.json and assumed it was 3.1. Build should update to 3.1. It is a LTS release. 3.0 is no longer supported. |
jtattermusch
force-pushed
the
csharp_benchmark_improvements
branch
from
July 1, 2020 05:53
c582db8
to
45c8850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinaryPrimitives.WriteUInt64LittleEndian
for writing fixed64 values as starting from .NET Core 3.x, this is much faster than the current workaround.Changes are mostly taken from JamesNK@337780c (as recommended here #7576 (comment) for more context). Thanks @JamesNK for the improvements!