[bazel] Move Objective-C runtime into //objectivec #7694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing language-specific targets from the top-level BUILD file will allow users to keep their workspaces smaller and easier to maintain by not depending on language rules they don't need. Similar work was done for Java in protocolbuffers#7190.
|
@acozzette As usual I forgot to add the new file to the PTAL, thanks! |
|
@acozzette Thanks! The remaining failures look unrelated to the change. |
|
@thomasvl Do you have any thoughts on this change? |
nope. The bazel support hasn't been something I've really been looped into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing language-specific targets from the top-level BUILD file
will allow users to keep their workspaces smaller and easier to
maintain by not depending on language rules they don't need.
The top-level targets are kept as an alias, so this is not a breaking
change. There is currently no intention to deprecate and remove
the top-level targets.
Similar work was done for Java in #7190.