Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port php c extension to php8 #7789

Closed
wants to merge 1 commit into from
Closed

Port php c extension to php8 #7789

wants to merge 1 commit into from

Conversation

TeBoring
Copy link
Contributor

@TeBoring TeBoring commented Aug 8, 2020 •
edited

Fixes #7720, #7721

@TeBoring
Copy link
Contributor Author

TeBoring commented Aug 8, 2020

@haberman Still missing arginfo for types added in bundled_php.c. Do you know how to add arginfo for those?
BTW, missing arginfo causes php to throw warnings, which is written to STDOUT. That will stall our conformance test.

@TeBoring TeBoring requested a review from haberman August 8, 2020 18:04
@TeBoring
Copy link
Contributor Author

Pursued in #7793

@TeBoring TeBoring closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haberman haberman Awaiting requested review from haberman

Assignees
No one assigned
Labels
cla: yes php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TeBoring @googlebot @protobuf-kokoro