Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include sys/param.h for _BYTE_ORDER #8106

Merged
merged 1 commit into from Dec 2, 2020
Merged

Don't include sys/param.h for _BYTE_ORDER #8106

merged 1 commit into from Dec 2, 2020

Commits on Dec 2, 2020

  1. Don't include sys/param.h for _BYTE_ORDER 

    It includes a bunch of other files including a lot of macros which can
reduce the namespace available for actual protobuf.

For example, create a protobuf with a member called SIGSEGV. Since
macros cannot be namespaced in C++ this results in code which cannot be
compiled.

Fix this by just directly including endian.h
    @giannitedesco
    giannitedesco committed Dec 2, 2020
    Copy the full SHA
    339f622 View commit details
    Browse the repository at this point in the history