Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PhpDoc comments for message accessors to include "|null". #8136

Merged
merged 1 commit into from Jan 7, 2021
Merged

Fix PhpDoc comments for message accessors to include "|null". #8136

merged 1 commit into from Jan 7, 2021

Commits on Dec 11, 2020

  1. Fix PhpDoc comments for message accessors to include "|null". 

    Message accessors will return null when when the field is not
set, so this should be reflected in the PhpDoc.

Also updated the code generator for the well-known types to reflect
the edits made in protocolbuffers#8105.

Also explicitly check for upb_msg_has() in the oneof accessor, so
we are not implicitly relying on unset message fields returning NULL
at the upb level.
    @haberman
    haberman committed Dec 11, 2020
    Copy the full SHA
    5f844c7 View commit details
    Browse the repository at this point in the history