Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Ruby extension to upb_msg #8184

Merged
merged 47 commits into from Jan 13, 2021

Commits on Aug 4, 2020

  1. WIP.

    haberman committed Aug 4, 2020
    Copy the full SHA
    d4de4e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. WIP.

    haberman committed Aug 12, 2020
    Copy the full SHA
    fed4b6c View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. WIP.

    haberman committed Aug 17, 2020
    Copy the full SHA
    f69c62f View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. WIP.

    haberman committed Sep 9, 2020
    Copy the full SHA
    e6199a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. WIP.

    haberman committed Sep 10, 2020
    Copy the full SHA
    b916a7e View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. WIP.

    haberman committed Sep 21, 2020
    Copy the full SHA
    b534dc1 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Copy the full SHA
    c128e55 View commit details
    Browse the repository at this point in the history
  2. Added some missing files.

    haberman committed Nov 17, 2020
    Copy the full SHA
    8675752 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. WIP.

    haberman committed Nov 18, 2020
    Copy the full SHA
    7338f03 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. WIP.

    haberman committed Nov 23, 2020
    Copy the full SHA
    3e99f6b View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2020

  1. Updated upb.

    haberman committed Dec 5, 2020
    Copy the full SHA
    c1b97a9 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. Copy the full SHA
    8ca5f9c View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Gets through the test suite without SEGV!

    Still a lot of bugs to fix, but it is a major step!
    
    214 tests, 378 assertions, 37 failures, 147 errors, 0 pendings, 0 omissions, 0 notifications
    14.0187% passed
    haberman committed Dec 9, 2020
    Copy the full SHA
    2fbc33b View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Test and build for Ruby 3.0

    qnighy committed Dec 11, 2020
    Copy the full SHA
    f282bac View commit details
    Browse the repository at this point in the history
  2. Fixed a few more bugs, efficient #inspect is almost done.

    214 tests, 134243 assertions, 30 failures, 144 errors, 0 pendings, 0 omissions, 0 notifications
    18.6916% passed
    haberman committed Dec 11, 2020
    Copy the full SHA
    a40acfe View commit details
    Browse the repository at this point in the history
  3. Fixed message hash initialization and encode depth checking.

    214 tests, 124651 assertions, 53 failures, 70 errors, 0 pendings, 0 omissions, 0 notifications
    42.5234% passed
    haberman committed Dec 11, 2020
    Copy the full SHA
    59c544e View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2020

  1. A bunch of fixes to failing tests, now 70% passing.

    214 tests, 202091 assertions, 41 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications
    70.0935% passed
    haberman committed Dec 12, 2020
    Copy the full SHA
    d7afcfa View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. More than 80% of tests are passing now.

    214 tests, 322331 assertions, 30 failures, 9 errors, 0 pendings, 0 omissions, 0 notifications
    81.7757% passed
    
    Unfortunately there is also a sporadic bug/segfault hanging around
    that appears to be GC-related.
    haberman committed Dec 13, 2020
    Copy the full SHA
    978f2b8 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Copy the full SHA
    ac5a9ce View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    7f585f3 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    9891063 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. Over 90% of tests are passing!

    214 tests, 349898 assertions, 15 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications
    92.5234% passed
    haberman committed Dec 18, 2020
    Copy the full SHA
    dd05452 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Passes all tests!

    214 tests, 369388 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
    100% passed
    haberman committed Dec 22, 2020
    Copy the full SHA
    ac7e9d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2020

  1. A bunch of cleanup.

    1. Removed a bunch of internal-only symbols from headers.
    2. Required a frozen check to get a non-const pointer to a map or array.
    3. De-duplicated the code to get a type argument for Map/RepeatedField.
    haberman committed Dec 26, 2020
    Copy the full SHA
    113800b View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    b65352f View commit details
    Browse the repository at this point in the history
  3. Removed a bunch more stuff from protobuf.h. There is an intermittent …

    …assert failure.
    
    Intermittent failure:
    
    ruby: ../../../../ext/google/protobuf_c/protobuf.c:263: ObjectCache_Add: Assertion `rb_funcall(obj_cache2, (__builtin_constant_p("[]") ? __extension__ ({ static ID rb_intern_id_cache; if (!rb_intern_id_cache) rb_intern_id_cache = rb_intern2((("[]")
    ), (long)strlen(("[]"))); (ID) rb_intern_id_cache; }) : rb_intern("[]")), 1, key_rb) == val' failed
    haberman committed Dec 26, 2020
    Copy the full SHA
    e3a58ea View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    96ac69e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Copy the full SHA
    dc65f39 View commit details
    Browse the repository at this point in the history
  2. Ruby 3.0.0-preview2 to 3.0.0

    qnighy committed Dec 28, 2020
    Copy the full SHA
    2f4f698 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2021

  1. Copy the full SHA
    46df88e View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    4b58485 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    2ba3bdb View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Copy the full SHA
    4d97d7c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    1702846 View commit details
    Browse the repository at this point in the history
  3. Fixed the wyhash compile.

    haberman committed Jan 5, 2021
    Copy the full SHA
    773b033 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Fixed conformance tests for Ruby.

    Conformance results now look like:
    
    RUBYLIB=../ruby/lib:. ./conformance-test-runner --enforce_recommended --failure_list failure_list_ruby.txt --text_format_failure_list text_format_failure_list_ruby.txt ./conformance_ruby.rb
    
    CONFORMANCE TEST BEGIN ====================================
    
    CONFORMANCE SUITE PASSED: 1955 successes, 0 skipped, 58 expected failures, 0 unexpected failures.
    
    CONFORMANCE TEST BEGIN ====================================
    
    CONFORMANCE SUITE PASSED: 0 successes, 111 skipped, 8 expected failures, 0 unexpected failures.
    
    Fixes include:
    
    - Changed Ruby compiler to no longer reject proto2 maps.
    - Changed Ruby compiler to emit a warning when proto2 extensions are
      present instead of rejecting the .proto file completely.
    - Fixed conformance tests to allow proto2 and look up message by name
      instead of hardcoding a specific list of messages.
    - Fixed conformance test to support the "ignore unknown" option for
      JSON.
    - Fixed conformance test to properly report serialization errors.
    haberman committed Jan 6, 2021
    Copy the full SHA
    a0b4fd3 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Copy the full SHA
    206ef59 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    53d7f28 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Copy the full SHA
    2b7ba72 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a8d8fe3 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    1b1438f View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Copy the full SHA
    b27ca67 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    aa728a7 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    e9af5a2 View commit details
    Browse the repository at this point in the history
  4. Some more refactoring.

    haberman committed Jan 9, 2021
    Copy the full SHA
    b7be808 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2021

  1. Copy the full SHA
    ea83e5d View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Copy the full SHA
    0b8040b View commit details
    Browse the repository at this point in the history