Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert native PHP floats to single precision #8187

Merged
merged 2 commits into from Jan 11, 2021
Merged

fix: convert native PHP floats to single precision #8187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9900fb
fix: convert native PHP floats to single precision
bshaffer Jan 6, 2021
2b42e60
fix unpack
bshaffer Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion php/src/Google/Protobuf/Internal/GPBUtil.php
View file
Open in desktop
Expand Up @@ -168,7 +168,7 @@ public static function checkUint64(&$var)
public static function checkFloat(&$var)
{
if (is_float($var) || is_numeric($var)) {
$var = floatval($var);
$var = unpack("f", pack("f", $var))[1];
} else {
throw new \Exception("Expect float.");
}
Expand Down