Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve more java field accessor name conflicts #8198

Commits on Jan 10, 2021

  1. Remove javanano from .gitignore.

    Ignore java/lite/target
    philsttr committed Jan 10, 2021
    Copy the full SHA
    af6ce22 View commit details
    Browse the repository at this point in the history
  2. Resolve more java field accessor name conflicts.

    Previously, some proto field names would cause the java code generator to generate accessor names that conflict with method names from the message super classes/interfaces.
    A list of field names that cause such conflicts previously existed, but the list did not contain every field name that would cause a conflict.
    Additionally, only snake_case field names would be detected. If the field name was in camelCase, the conflict would not be detected.
    
    This change adds the complete set of field names that will cause assessor name conflicts, and detects conflicts in both snake_case and camelCase field names.
    
    Fixes protocolbuffers#8142
    philsttr committed Jan 10, 2021
    Copy the full SHA
    2529c60 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Prevent java accessor name conflicts for fields with leading undersco…

    …res.
    
    Previously, some protobuf field names beginning with leading underscores (e.g. _class) would cause uncompilable java code to be generated due to assessor name conflicts.
    Now, non-conflicting java accessor method names are created for those fields
    philsttr committed Feb 19, 2021
    Copy the full SHA
    7da00a5 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Copy the full SHA
    1f8baae View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. Improve comments/documentation for conversion from snake case to came…

    …l case
    
    Rename snakeCaseToCamelCase to snakeCaseToLowerCamelCase
    Add snakeCaseToUpperCamelCase
    Add clarifying in-line comments for field name generation
    Remove explicit version numbers from references.
    philsttr committed Oct 24, 2021
    Copy the full SHA
    4038de8 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'resolve_java_field_name_accessor_conflict' of github.co…

    …m:philsttr/protobuf into resolve_java_field_name_accessor_conflict
    philsttr committed Oct 24, 2021
    Copy the full SHA
    7c0c1fc View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. Fix indents and typo

    philsttr committed Nov 5, 2021
    Copy the full SHA
    9f88f0c View commit details
    Browse the repository at this point in the history
  2. Unnest <pre> tag

    philsttr committed Nov 5, 2021
    Copy the full SHA
    8663cff View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. improve grammar in comments

    are colliding -> collide
    philsttr committed Nov 8, 2021
    Copy the full SHA
    bbd504b View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ce16ade View commit details
    Browse the repository at this point in the history
  3. Fix typo in comment

    philsttr committed Nov 8, 2021
    Copy the full SHA
    7427439 View commit details
    Browse the repository at this point in the history