Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow FileDescriptors to be parsed with extension registries #8220

Merged
merged 2 commits into from Feb 1, 2021
Merged

Allow FileDescriptors to be parsed with extension registries #8220

merged 2 commits into from Feb 1, 2021

Commits on Jan 20, 2021

  1. Include the size of values (and tags) for extensions, even if the val… 

    …ue is the default

Fixes protocolbuffers#8218.
    @jskeet
    jskeet committed Jan 20, 2021
    Copy the full SHA
    cea3653 View commit details
    Browse the repository at this point in the history

  2. Add an extension registry option when parsing file descriptors 

    This is important when parsing descriptor sets that contain extensions.
(The alternative is to get the descriptor bytes again for individual
elements, e.g. message descriptors, and reparse them with the
appropriate extensions. It's really ugly.)
    @jskeet
    jskeet committed Jan 20, 2021
    Copy the full SHA
    f01d9e5 View commit details
    Browse the repository at this point in the history