Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io/coded_stream: assume Windows is little endian #8261

Closed
wants to merge 1 commit into from
Closed

io/coded_stream: assume Windows is little endian #8261

wants to merge 1 commit into from

Conversation

1480c1
Copy link

@1480c1 1480c1 commented Feb 4, 2021

mingw-w64 lacks endian.h, but had sys/param.h meaning
a91adf1 broke non-msvc windows
compilation

Signed-off-by: Christopher Degawa ccom@randomderp.com

mingw-w64 lacks endian.h, but had sys/param.h meaning
a91adf1 broke non-msvc windows
compilation

Signed-off-by: Christopher Degawa <ccom@randomderp.com>
@acozzette
Copy link
Member

@1480c1 Thanks so much for this pull request but I am going to close this because we ended up already merging the same fix in #8286.

@acozzette acozzette closed this Feb 17, 2021
@1480c1 1480c1 deleted the mingw-w64/endian branch February 17, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants