Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbounded memory growth for Ruby <2.7. #8429

Merged
merged 4 commits into from Mar 29, 2021
Merged

Fix unbounded memory growth for Ruby <2.7. #8429

merged 4 commits into from Mar 29, 2021

Commits on Mar 25, 2021

  1. GC secondary map periodically.

    @haberman
    haberman committed Mar 25, 2021
    Copy the full SHA
    b75a49f View commit details
    Browse the repository at this point in the history

  2. Wrap secondary map mutations in a mutex, to avoid mutation races.

    @haberman
    haberman committed Mar 25, 2021
    Copy the full SHA
    f0d6fcb View commit details
    Browse the repository at this point in the history

  3. Added some more comments and refactored slightly.

    @haberman
    haberman committed Mar 25, 2021
    Copy the full SHA
    e1ac393 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Addressed PR comments and fixed a bug. 

    We now hold the mutex for both map insertions, to protect
against a concurrent GC that removes from the seconary map
before we can insert into the weak map.
    @haberman
    haberman committed Mar 29, 2021
    Copy the full SHA
    2fe27d8 View commit details
    Browse the repository at this point in the history