Use C++11 enum class for Utf8CheckMode #8490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
reviewed
Apr 14, 2021
| VERIFY = 1, // Only log an error but parsing will succeed. | ||
| NONE = 2, // No UTF-8 check. | ||
| enum class Utf8CheckMode { | ||
| Strict = 0, // Parsing will fail if non UTF-8 data is in string fields. |
There was a problem hiding this comment.
Looks great to me but one small thing: our style for enum names is to name them kStrict, kVerify, kNone. (Sometimes we don't use that convention in our existing code because our previous convention was to use ALL_CAPS names.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time this enum includes members named STRICT and NONE, both of which are known to have problems under Windows (at least
port_undef.inchas workaround for this macro).As protobuf now builds in C++11 mode,
enum classis a better solution to avoid name conflicts.This is part 1 / x in #8494 fix.