Remove trivial methods from the codebase #8498
Conversation
| @@ -1011,29 +1011,16 @@ bool IsWellKnownMessage(const FileDescriptor* file) { | |||
| return well_known_files.find(file->name()) != well_known_files.end(); | |||
| } | |||
|
|
|||
| static bool FieldEnforceUtf8(const FieldDescriptor* field, | |||
There was a problem hiding this comment.
Sorry but unfortunately we need to keep these functions around. Within our internal version of the codebase we have some additional code in these functions for legacy reasons, to allow the UTF-8 enforcement to be disabled for particular fields. Even though the functions look pointless, it helps us to have them around so that we can easily apply our internal changes.
If you just want to fix an unused-parameter warning, it would be fine to remove the parameter names (i.e. just make it (const FieldDescriptor*, const Options&)) or add lines like (void) field;.
There was a problem hiding this comment.
I am not working on unused parameter in protoc itself, but rather in the generated code.
It is ok if these methods would not be removed, though this will make interfaces a bit clumsier.
Could you, please, take a look on the question below?
|
@acozzette, @haberman could you, please, take a look onto GetOptimizeFor implelementation in cpp_helpers.cc? Internally it invokes The method was introduced during sync from Google's internal codebase in b99994d, so there may be additional details available internally. |
|
I believe the calls to |
|
Ok, thanks for the clarification. I am closing thing PR due to the reasoning from above, |
This simplifies the code in GetUtf8CheckMode dramatically.
This is part 2 / x in #8494 fix.