Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix -Wunused-parameter in map<string, int> fields (fixes #8494) #8500

Merged
merged 2 commits into from Apr 16, 2021
Merged

Fix -Wunused-parameter in map<string, int> fields (fixes #8494) #8500

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c3a0f9
Fix -Wunused-parameter in map<string, int> fields
georgthegreat Apr 16, 2021
615bb01
Fix tabs
georgthegreat Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/google/protobuf/compiler/cpp/cpp_map_field.cc
View file
Open in desktop
Expand Up @@ -229,7 +229,10 @@ void MapFieldGenerator::GenerateSerializeWithCachedSizesToArray(
if (utf8_check) {
format(
"struct Utf8Check {\n"
" static void Check(ConstPtr p) {\n");
" static void Check(ConstPtr p) {\n"
// p may be unused when GetUtf8CheckMode evaluates to kNone,
georgthegreat marked this conversation as resolved.
Show resolved Hide resolved
// thus disabling the validation.
" (void)p;\n");
format.Indent();
format.Indent();
if (string_key) {
Expand Down