Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated and simplified PHP testing structure #8558

Merged
merged 11 commits into from May 4, 2021
Merged

Updated and simplified PHP testing structure #8558

merged 11 commits into from May 4, 2021

Commits on May 3, 2021

  1. Simplified PHP testing setup. 

    - Consolidated on a single autoloader, created by composer.
- Consolidated on a single phpunit invocation strategy: we run
  phpunit on a directory, which will run all tests matching *Test.php
  in that directory.
- We now rely on autoloading to import all test protos. require_once()
  calls for test protos are removed.
- For now the valgrind tests are removed. A follow-up PR will re-enable
  them in a more robust way.
    @haberman
    haberman committed May 3, 2021
    Configuration menu
    Copy the full SHA
    7f9c4ae View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. More improvements to PHP testing. 

    1. Replace custom PHPUnit-selection logic in test.sh with generic
   composer version selection.
2. Optimized both test proto generation and the custom extension
   build to avoid unnecessary work when the files are already up
   to date.
    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    2d679de View commit details
    Browse the repository at this point in the history

  2. Added assertions to verify that the C test doesn't use PHP sources.

    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    c058d00 View commit details
    Browse the repository at this point in the history

  3. Updated tests.sh for the new PHP testing commands.

    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    9083c3d View commit details
    Browse the repository at this point in the history

  4. Removed obsolete rules from tests.sh.

    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f5ac4d1 View commit details
    Browse the repository at this point in the history

  5. Fixed generate_test_protos.sh for when tmp does not exist. 

    Also removed undefined_test.php and fixed Makefile.am.
    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    c4720b4 View commit details
    Browse the repository at this point in the history

  6. Added php8.0_all again which is still used.

    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    82154df View commit details
    Browse the repository at this point in the history

  7. Added missing file to Makefile.am.

    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    ba9539c View commit details
    Browse the repository at this point in the history

  8. Re-added php_all_32 rule which is also still used.

    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    da2d7f3 View commit details
    Browse the repository at this point in the history

  9. Updated testing commands for macOS and download composer.

    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f9e5b7c View commit details
    Browse the repository at this point in the history

  10. Use /usr/local/bin on mac instead of /usr/bin, since the latter is no… 

    …t writable.
    @haberman
    haberman committed May 4, 2021
    Configuration menu
    Copy the full SHA
    dc2d2b0 View commit details
    Browse the repository at this point in the history