Adopt pure ruby DSL implementation for JRuby #8997
Conversation
Since this is the rake target used by kokoro, this will close the gem release gap for JRuby Should help protocolbuffers#7923 by making sure JRuby is built and released as part of the normal cadence.
…olves most test failures under JRuby 9.2.11.1
…olves most test failures under JRuby 9.2.11.1
…tests # Conflicts: # ruby/src/main/java/com/google/protobuf/jruby/RubyDescriptorPool.java
…olves all unit test failures under JRuby 9.2.11.1
* Protobuf: Fix for C5041 for VC++ > 15.5 Introduced in 15.5: https://docs.microsoft.com/en-us/cpp/overview/cpp-conformance-improvements-2017?view=msvc-160#inline-variables 15.5 is 1912: https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160 Issue: protocolbuffers#8978 * Fix comment wording for protocolbuffers#8978
* deps: add j2objc annotations @pzd this will be needed on the next sync with google3
…xed, and signed scalar types as supported map keys. Reset JRuby conformance test expectations to align with the superset of expected failures from both Ruby and Java. Includes minor cleanups to fix typos, to remove unused variables, unused private methods, and unused imports, and improve formatting.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Closing in favor of #9047 |
Also squashes all current JRuby unit test failures and resets expectations about known conformance test failures to be the super set of Java + Ruby known failures.
Includes all changes separately posted under #8954