Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.1 compatibility #9359

Closed
wants to merge 1 commit into from

Conversation

Yurunsoft
Copy link

Fix Deprecated such as:

Deprecated: Return type of Google\Protobuf\Internal\RepeatedFieldIter::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in

@caugner
Copy link

caugner commented Jan 14, 2022

Fixes #9293.

@Dragomeat
Copy link

Does anyone know when this pr will be merged and released?

@caugner
Copy link

caugner commented Jan 31, 2022

@Dragomeat It looks like #9370 is more promising, since the tests are already passing.

@haberman
Copy link
Member

haberman commented Feb 1, 2022

Agreed, I am closing this in favor of #9370.

@haberman haberman closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants