Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing php 8.1 deprecation warnings #9370

Merged
merged 13 commits into from Feb 2, 2022
Merged

fixing php 8.1 deprecation warnings #9370

merged 13 commits into from Feb 2, 2022

Commits on Jan 5, 2022

  1. fixing php 8.1 deprecation warnings

    php 8.1 is more strict, and raises some deprecation notices with existing protobuf code. Not all of the
    deprecations can be fixed without dropping support for php7.x (eg, the 'mixed' type doesn't appear until
    8.1, and union types until 8.0, but as an interim solution the 'ReturnTypeWillChange' attribute can be
    used to suppress the notices. In passing, also be explicit about a cast from float to int in 'zigZagEncode64'
    which 8.1 also complains about when running tests.
    brettmc committed Jan 5, 2022
    Copy the full SHA
    c26b1c8 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Copy the full SHA
    fabe73d View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. require bcmath

    bcmath (specifically, the bccomp function) is internally required, and tests fail if it's not available
    brettmc committed Jan 10, 2022
    Copy the full SHA
    558d128 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. conditionally adding mixed return type

    With guidance from Remi Collet, use ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_EX macro, and use a conditional to fake that macro
    for earlier php versions. Tested on 8.1 and 7.4, and deprecation notices gone plus all tests pass
    brettmc committed Jan 13, 2022
    Copy the full SHA
    0476a89 View commit details
    Browse the repository at this point in the history
  2. bump extension min version to 7.2

    The macro ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX changed in 7.2, so it cannot be used in a compatible
    way with earlier versions
    brettmc committed Jan 13, 2022
    Copy the full SHA
    9e65df2 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. php 7.0 support

    instead of using the void return type, add more ReturnTypeWillChange annotations
    brettmc committed Jan 19, 2022
    Copy the full SHA
    bfe33d7 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. fixing typo in comment

    brettmc committed Jan 20, 2022
    Copy the full SHA
    f689268 View commit details
    Browse the repository at this point in the history
  2. working 7.0 extension

    brettmc committed Jan 20, 2022
    Copy the full SHA
    c62cbe9 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Copy the full SHA
    110d6c1 View commit details
    Browse the repository at this point in the history
  2. tidy

    brettmc committed Jan 24, 2022
    Copy the full SHA
    6a3f384 View commit details
    Browse the repository at this point in the history
  3. formatting

    brettmc committed Jan 24, 2022
    Copy the full SHA
    3e724d8 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. removing ext-bcmath require

    I think it _should_ be required, but a test (linux, 32bit, 7.0-zts) is choking
    on composer install, so putting things back to how I found them
    brettmc committed Jan 25, 2022
    Copy the full SHA
    a78b89e View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. php8.1 testing

    brettmc committed Jan 27, 2022
    Copy the full SHA
    4c03fcf View commit details
    Browse the repository at this point in the history