Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Standardize on Array copyOf" #9400

Merged
merged 1 commit into from Jan 11, 2022
Merged

Revert "Standardize on Array copyOf" #9400

merged 1 commit into from Jan 11, 2022

Commits on Jan 11, 2022

  1. Revert "Standardize on Array copyOf" 

    This reverts commit 935d099 from PR protocolbuffers#9162.

While the original commit was a nice simplification, I learned from
another Googler that there is unfortunately a performance cost to this
(or at least there was last time this change was attempted). Even if it
turns out to be fast on modern Java runtimes, we still care about the
performance on old Android devices.
    @acozzette
    acozzette committed Jan 11, 2022
    Copy the full SHA
    fe4bc64 View commit details
    Browse the repository at this point in the history