Revert "Add an option to preserve proto names in JsonFormatter"

[jtattermusch]

Reverts #6307

• there is a large white-space only diff that obscures the real changes, which is really bad for maintenance. Let's reintroduce the PR without the whitespace changes so that the correct diff is shown in github UI.
• there's been some other concerns with the PR (see comment thread on Add an option to preserve proto names in JsonFormatter #6307).

We'll be happy to accept the PR again once the concerns from the review are addressed and once the diff looks fine.

@ObsidianMinor

[jskeet]

Hmm... creating a new commit to revert will only help fix some of the issues by merging the giant whitespace change. git annotate will still show "this was all changed in a single commit". Basically it's hard to get back to a nice diff without rewriting history at this point :(

I would suggest that we should probably:

• Check what the actual whitespace changes are (e.g. was it LF -> CRLF, CRLF -> LF or something different?)
• Work out what we want the whitespace to be (check other files)
• Make other changes to JsonFormatter as desired. (I don't think it's anything semantic, just some formatting/description changes.)

[jtattermusch]

Fair enough, I'll close the PR. Filed #9526 to address the CRLF inconsistencies.

Hmm... creating a new commit to revert will only help fix some of the issues by merging the giant whitespace change. git annotate will still show "this was all changed in a single commit". Basically it's hard to get back to a nice diff without rewriting history at this point :(

I would suggest that we should probably:

• Check what the actual whitespace changes are (e.g. was it LF -> CRLF, CRLF -> LF or something different?)
• Work out what we want the whitespace to be (check other files)
• Make other changes to JsonFormatter as desired. (I don't think it's anything semantic, just some formatting/description changes.)