Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a generation option to control use of forward declarations in headers. #9568

Merged
merged 1 commit into from Mar 3, 2022
Merged

Add a generation option to control use of forward declarations in headers. #9568

merged 1 commit into from Mar 3, 2022

Commits on Mar 3, 2022

  1. Add a generation option to control use of forward declarations in hea… 

    …ders.

Swift importing ObjC drops methods/properties if the type is only a forward
declaration since the type is incomplete. Historically the generator has always
use forward declarations to reduce how much will have rebuild when a proto file
does change; but that puts it at odds with Swift. If ObjC Protos end up spanning
Swift modules, the Swift import behavior could become a problem; so this option
provides a control for the behavior. The current behavior is to continue forward
declarations, but eventually the default will be changed.

Generate the WKTs using imports instead of forward decls.
    @thomasvl
    thomasvl committed Mar 3, 2022
    Copy the full SHA
    dd56fe2 View commit details
    Browse the repository at this point in the history