Compiler server #446
Merged
Compiler server #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-inserter-failure [PE-1779] add retry in case of inserter failure
- This adds a way to specify which namespace the config should be written to. If not set, the namespace provided by the command line will be used. - Specifying `namespace` inside `RolloutConfig` will make the inserter switch to `configmaps` store engine regardless of what specified by default Additional fix: - normalize config file with `materialized_config/<filepath>.materialized_JSON` prefixes and suffixes. Users can now use any combination of with/without prefix and suffix.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
===========================================
- Coverage 71.63% 44.52% -27.11%
===========================================
Files 15 56 +41
Lines 1657 5471 +3814
===========================================
+ Hits 1187 2436 +1249
- Misses 337 2783 +2446
- Partials 133 252 +119 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.