adding simple JSONP support #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should add transparent JSONP support to all browsers that PrototypeJS supports.
|
Let's pencil this in for 1.8. |
|
no worries - had this PR sitting on my laptop and seeing all the updates reminded me to open this. |
|
Despite jQuery's way of handling this, I'm hesitant to make it part of |
|
actually that would make it very clear if the dev was expecting JSONP to use the JSONPRequest method (and don't name it JSONRequest thats confusing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #197 , this should add transparent JSONP support to all browsers that PrototypeJS supports.
I added unit tests for a cross domain url but was exactly sure how to make WEBrick do it correctly.