Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io-metrics to topic and broker, adapting the active controller in the context of Kraft #4369

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

liudaac
Copy link

@liudaac liudaac commented Feb 2, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  1. Add metrics to topic list. Such as ByteIn /sec, Byteout /sec, Msg /sec, Msg-5min /sec, Fetch /sec, Fetch-5min /sec, Produce /sec, Produce-5min /sec.
  2. Add metrcis to broker list. Such as IN /sec, OUT /sec.
  3. Add fields to metrics class.
  4. The source of controller information is changed to first obtain it from the kafka.controller in metrics, thereby adapting to the Kraft protocol. If not available, then AdminClient is used.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: daliu <liudaax@126.com>
@liudaac liudaac requested review from a team as code owners February 2, 2024 06:58
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there liudaac! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

Signed-off-by: daliu <liudaax@126.com>
Signed-off-by: daliu <liudaax@126.com>
Signed-off-by: daliu <liudaax@126.com>
Signed-off-by: daliu <liudaax@126.com>
Signed-off-by: daliu <liudaax@126.com>
@liudaac liudaac changed the title Add io-metrics to topic and broker Add io-metrics to topic and broker and fix error-activeController bug Feb 4, 2024
Signed-off-by: daliu <liudaax@126.com>
Signed-off-by: daliu <liudaax@126.com>
Signed-off-by: daliu <liudaax@126.com>
Signed-off-by: daliu <liudaax@126.com>
Signed-off-by: daliu <liudaax@126.com>
@liudaac
Copy link
Author

liudaac commented Feb 4, 2024

There is two failure exists:
a.Frontend failed for
ERROR: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

b.E2E failed for aws config

Apart from those configuration issues set by the project manager, everything else has been successfully executed.

@liudaac liudaac changed the title Add io-metrics to topic and broker and fix error-activeController bug Add io-metrics to topic and broker, adapting the active controller in the context of Kraft Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant