-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Remove useless cache locks in LRUs #13794
base: develop
Are you sure you want to change the base?
[WIP] Remove useless cache locks in LRUs #13794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general rule, it would be much easier to review these changes if you split it into different PRs by each specific cache. Some of these are on critical paths, so being able to review them independently is important. Also in the event any change breaks something we can simply revert the PR to the specific cache rather than for all the caches.
You are absolutely correct. I have kept this PR as a work in progress because it has grown larger than what is typically acceptable, as you pointed out. However, I have kept it for a few reasons:
I have broken down the commits per service to make it easier for me to cherry-pick the changes on a per-PR basis. Could you please indicate which cache you would like to see this implementation for in the first review as I am nearly finished? Thank you! |
@v4lproik I have no preference on the order of caches to review. Feel free to open PRs in any order you would like |
@nisdas I have opened the rework of the Committees Cache if you want to have a look at it. |
What type of PR is this?
Enhancement
Bug fix
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
#13723
Other notes for review