Submit all slot attestations at once #13809
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Mar 27, 2024
| v.SubmitAttestation(slotCtx, slot, pubKey) | ||
| data := v.GetAttestationData(slotCtx, slot, pubKey) | ||
| if data != nil { | ||
| lock.Lock() |
There was a problem hiding this comment.
append is not thread-safe when the size of the slice is predefined
rkapka
commented
Mar 27, 2024
| @@ -235,6 +236,27 @@ func LogsContain(loggerFn assertionLoggerFn, hook *test.Hook, want string, flag | |||
| } | |||
| } | |||
|
|
|||
| // LogsDontHaveErrors checks whether there are no error logs in the output. | |||
| func LogsDontHaveErrors(loggerFn assertionLoggerFn, hook *test.Hook, msg ...interface{}) { | |||
There was a problem hiding this comment.
This is much more robust than what we have now, which is checking that no Could not logs exits. Not all error logs in the function have this format.
saolyn
reviewed
Mar 27, 2024
validator/client/attest.go
Outdated
| log.WithError(err).Error("Failed attestation slashing protection check") | ||
| log.WithFields( | ||
| attestationLogFields(pubkeys[i], indexedAtt), | ||
| ).Debug("Attempted slashable attestation details") |
There was a problem hiding this comment.
What does this message mean? Is it details of an attempted slashable attestation?
| @@ -134,7 +134,7 @@ type ValidatorClient interface { | |||
| PrepareBeaconProposer(ctx context.Context, in *ethpb.PrepareBeaconProposerRequest) (*empty.Empty, error) | |||
| GetFeeRecipientByPubKey(ctx context.Context, in *ethpb.FeeRecipientByPubKeyRequest) (*ethpb.FeeRecipientByPubKeyResponse, error) | |||
| GetAttestationData(ctx context.Context, in *ethpb.AttestationDataRequest) (*ethpb.AttestationData, error) | |||
| ProposeAttestation(ctx context.Context, in *ethpb.Attestation) (*ethpb.AttestResponse, error) | |||
| ProposeAttestations(ctx context.Context, in []*ethpb.Attestation) ([]*ethpb.AttestResponse, error) | |||
There was a problem hiding this comment.
Since we call GetAttestationData the same way here and in the validator, should we not keep the name of SubmitAttestations the same?
Suggested change
| ProposeAttestations(ctx context.Context, in []*ethpb.Attestation) ([]*ethpb.AttestResponse, error) | |
| SubmitAttestations(ctx context.Context, in []*ethpb.Attestation) ([]*ethpb.AttestResponse, error) |
rkapka
force-pushed
the
submit-all-atts
branch
2 times, most recently
from
6a7c5c5
to
fa9a82e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/submitPoolAttestations Beacon API endpoint allows submitting multiple attestations in a single request. We currently do not take advantage of this and submit one attestation at a time. To allow this the PR extracts a
GetAttestationDatafunction fromSubmitAttestationso that we can build up a slice of attestation data values and pass it all at once for submission.