New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Psalm v5 #288
base: 5.x
Are you sure you want to change the base?
Switch to Psalm v5 #288
Conversation
This would very much tick this issue: #285 |
@danog you should also fix https://github.com/psalm/psalm-plugin-symfony/actions/runs/3596019841/jobs/6062735638 , i.e. remove use ReflectionClass;
use ReflectionException; and escape them in code with leading |
Or I could also just run cs-fix, but there's still some work to be done on the psalm side :) |
@danog thank you very much for taking time to work on this. Do you have any time estimate when you can finish? Thanks! |
I'm afraid the taint issues are caused by the same stubs issue caused by this plugin, that's causing issues upstream with user_defined classes. |
In fact, analyzing this standalone code returns the taint issues as expected, but running psalm with the plugin enabled on the same file but without the class declarations doesn't:
|
No description provided.