Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.x] Fix console handler with named arguments and add more tests #300

Merged
merged 1 commit into from Jan 8, 2023

Conversation

mdeboer
Copy link
Contributor

@mdeboer mdeboer commented Jan 5, 2023

The plugin crashed when using arguments or options with named arguments. The existing tests weren't sufficient to trigger the problem so I wrote some that do.

This also applies to v5.x for which I'll submit a separate PR.

Copy link
Member

@seferov seferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants