Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstring too long (issue #1632 fix) #3044

Merged
merged 19 commits into from May 8, 2022
Merged

Docstring too long (issue #1632 fix) #3044

merged 19 commits into from May 8, 2022

Commits on May 3, 2022

  1. Check line length of last line of docstring to decide whether or not … 

    …to put closing quotes on next line
    @idorrington92
    idorrington92 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    471babd View commit details
    Browse the repository at this point in the history

  2. Fixing bugs. last_line_length must be 0 for empty strings and we need… 

    … to find last_line_length before beginning construction of final string
    @idorrington92
    idorrington92 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    0cd15a1 View commit details
    Browse the repository at this point in the history

  3. updating change log

    @idorrington92
    idorrington92 committed May 3, 2022
    Configuration menu
    Copy the full SHA
    6413776 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Moving change to preview style section

    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    3d27415 View commit details
    Browse the repository at this point in the history

  2. Adding to Preview

    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    e618a5a View commit details
    Browse the repository at this point in the history

  3. added tests for docstrings that go over line limit and one at the lin… 

    …e limit
    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    bbf6053 View commit details
    Browse the repository at this point in the history

  4. Converting to preview

    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    07fc574 View commit details
    Browse the repository at this point in the history

  5. using preview correctly this time

    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    ff75a6f View commit details
    Browse the repository at this point in the history

  6. Changing test to fit with using the preview now

    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    af631ef View commit details
    Browse the repository at this point in the history

  7. Adding preview tests and removing from regular test script

    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    06f907a View commit details
    Browse the repository at this point in the history

  8. Putting tests back

    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    ef3e6c3 View commit details
    Browse the repository at this point in the history

  9. Update tests/test_format.py 

    Co-authored-by: Felix Hildén <felix.hilden@gmail.com>
    @idorrington92 @felix-hilden
    idorrington92 and felix-hilden committed May 4, 2022
    Configuration menu
    Copy the full SHA
    ed261cb View commit details
    Browse the repository at this point in the history

  10. The logic was slighly wrong. It needed to account for the fact that m… 

    …ultiline strings have the indent included in all lines apart from the first one. Also, if the docstring has more than one line then we need to account for that there is only one set of quotes on the last line, not two
    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    9923e9c View commit details
    Browse the repository at this point in the history

  11. Merge branch 'docstring_too_ling' of https://github.com/idorrington92… 

    …/black into docstring_too_ling
    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    c52f493 View commit details
    Browse the repository at this point in the history

  12. renaming preview test file

    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    5ff6d8b View commit details
    Browse the repository at this point in the history

  13. added new test that checks multiline docstrings at the line limit

    @idorrington92
    idorrington92 committed May 4, 2022
    Configuration menu
    Copy the full SHA
    70b4164 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Fixing bug where prefix was sometimes considered in line length when … 

    …it shouldn't be
    @idorrington92
    idorrington92 committed May 5, 2022
    Configuration menu
    Copy the full SHA
    9e8dc5f View commit details
    Browse the repository at this point in the history

  2. Added tests with prefixes

    @idorrington92
    idorrington92 committed May 5, 2022
    Configuration menu
    Copy the full SHA
    cf6700f View commit details
    Browse the repository at this point in the history

  3. Fixing comments

    @idorrington92
    idorrington92 committed May 5, 2022
    Configuration menu
    Copy the full SHA
    85d5bf9 View commit details
    Browse the repository at this point in the history