New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[563] Fix standalone comments inside complex blocks crashing Black #4016
Merged
Commits on Nov 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c046388 - Browse repository at this point
Copy the full SHA c046388View commit details -
Fix standalone comment processing
Bracket depth is not an accurate indicator of standalone comment position inside more complex blocks because bracket depth can be virtual (in loops' and lambdas' parameter blocks) or from optional parens. Here we try to stop cumulating lines upon standalone comments in complex blocks, and try to make standalone comment processing more simple. The fundamental idea is, that if we have a standalone comment, it needs to go on its own line, so we always have to split. This is not perfect, but at least a first step.
Configuration menu - View commit details
-
Copy full SHA for bd3754c - Browse repository at this point
Copy the full SHA bd3754cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e42e19d - Browse repository at this point
Copy the full SHA e42e19dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e4cbbc - Browse repository at this point
Copy the full SHA 4e4cbbcView commit details
Commits on Nov 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 624cf9f - Browse repository at this point
Copy the full SHA 624cf9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a86c13a - Browse repository at this point
Copy the full SHA a86c13aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20fd2d2 - Browse repository at this point
Copy the full SHA 20fd2d2View commit details
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4dc7170 - Browse repository at this point
Copy the full SHA 4dc7170View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b1d969 - Browse repository at this point
Copy the full SHA 3b1d969View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.