Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'kwargs' to browser launch function #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

AVISIX
Copy link

@AVISIX AVISIX commented Jan 28, 2022

When working with the project, I had encountered a small issue where I had to pass specific kwargs to the browser's launch function.

I had to pass the following kwargs to the function:
handleSIGINT=False
handleSIGTERM=False
handleSIGHUP=False

I had to do this because I tried to call 'arender' in a seperate thread.

So I added the feature myself.

Added kwargs to BaseSession, so kwargs can be passed to the pyppeteer.launch function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant