Rename expirationTime/lifetime to what it really is: an idle timeout
#554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slamdunk
commented
Dec 23, 2022
| @@ -61,7 +61,7 @@ final class SessionMiddleware implements MiddlewareInterface | |||
| public function __construct( | |||
| Configuration $configuration, | |||
| SetCookie $defaultCookie, | |||
| private int $expirationTime, | |||
| private int $idleTimeout, | |||
There was a problem hiding this comment.
Schrödinger's BC break : it's backward incompatible only if you care about named parameters
There was a problem hiding this comment.
True, although IMO not worth pursuing this 👍
There was a problem hiding this comment.
Also, TIL that you can link labels, awesome!
Ocramius
approved these changes
Dec 23, 2022
Ocramius
changed the title
expirationTime/lifetime to what it really is: an idle timeout
|
Thanks @Slamdunk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #553 issue 1