Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lcobucci/jwt to ^4.3.0 and lcobucci/clock to v3 #557

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Update lcobucci/jwt to ^4.3.0 and lcobucci/clock to v3 #557

merged 3 commits into from
Jan 5, 2023

Conversation

Slamdunk
Copy link
Member

@Slamdunk Slamdunk commented Jan 5, 2023 •
edited by Ocramius

Replace #552 and #555 and Fix #555 CI failures

I propose myself as a Collaborator for this library, so in the future I'll be able to handle such contributions more effectively and autonomously. I'll still ask for review on BC break and API upgrades.

Fixes #555
Fixes #552

Ocramius
Ocramius approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @Slamdunk!

@Ocramius Ocramius self-assigned this Jan 5, 2023
@Ocramius Ocramius added enhancement dependencies Pull requests that update a dependency file labels Jan 5, 2023
@Ocramius Ocramius added this to the 8.14.0 milestone Jan 5, 2023
@Ocramius Ocramius merged commit e00f031 into psr7-sessions:8.14.x Jan 5, 2023
@Slamdunk Slamdunk deleted the lcobucci_clock_v3 branch January 5, 2023 09:50
@Slamdunk
Copy link
Member Author

Slamdunk commented Jan 5, 2023

Automatic release ouch: https://github.com/psr7-sessions/storageless/actions/runs/3845629578/jobs/6549994547

  [RuntimeException]                                                           
  API call to GitHub failed with status code 403 and message "You have exceed  
  ed a secondary rate limit. Please wait a few minutes before you try again."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
8.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Slamdunk @Ocramius