Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for Python 3.12 macOS arm64 wheels #1638

Conversation

reneleonhardt
Copy link
Contributor

I tried to install psycopg2-binary... and failed, that's a first 馃槄
So I added the missing 3.12 wheels and updated python_versions to the latest releases.

@dvarrazzo
Copy link
Member

dvarrazzo commented Oct 29, 2023 via email

@dvarrazzo
Copy link
Member

I'm waiting for a Scaleway machine to get free to make a macOS arm64 build.

@reneleonhardt
Copy link
Contributor Author

I'm waiting for a Scaleway machine to get free to make a macOS arm64 build.

I have Apple Silicon, is it possible for you to build remotely on my machine?

@@ -89,7 +89,7 @@ log "building wheels"
# Build the binary packages
export CIBW_PLATFORM=macos
export CIBW_ARCHS=arm64
export CIBW_BUILD='cp{38,39,310,311}-*'
export CIBW_BUILD='cp{38,39,310,311,312}-*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the part I had forgotten, sorry about that.

I managed to get a builder. Packages on the way.

@dvarrazzo
Copy link
Member

I have cherry-picked your change, thank you very much.

Missing package released on pypi.

@dvarrazzo dvarrazzo closed this Nov 1, 2023
@reneleonhardt
Copy link
Contributor Author

I have cherry-picked your change, thank you very much.

Why was a simple merge not possible? Now it looks like this PR has been closed unmerged, but the changes were introduced anyway, very confusing for future contributors lol
Before I spend my time helping a project I have to look if they just close PRs unmerged or if they welcome contributions, now the overview shows a green pipeline but the PR is red 馃お
https://github.com/psycopg/psycopg2/pulls?q=is%3Apr+is%3Aclosed

@dvarrazzo dvarrazzo reopened this Nov 1, 2023
@dvarrazzo dvarrazzo closed this Nov 1, 2023
@dvarrazzo dvarrazzo force-pushed the build-Python-3.12-macos-arm64-wheels branch from 37b9d57 to 941ac9a Compare November 1, 2023 17:32
@dvarrazzo
Copy link
Member

Your MR was based on master, but because we needed to package 2.9.9 it should have departed from the tag. So I cherry-picked in a branch from there, built the packages, and merged.

The alternative would have to force-push in this branch. I tried to do it now, re-opening and pushing, but the MR got "closed" again. I seem to remember it would have been merged.

It is the first time that someone asks me to have their MR status on github "right". Why? Does anyone keep the stats? For me github is just a web interface and we may decide to go somewhere else sometimes. What matters, for me, is the git history, and cherry-picking it maintains the attribution of your work:

commit 941ac9a72482f7d37584f43f9bd34063a3751aa5 (ren/build-Python-3.12-macos-arm64-wheels, origin/macos-arm64-py312, macos-arm64-py312, build-Python-3.12-macos-arm64-wheels)
Author: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
Date:   Sun Oct 29 14:57:07 2023 +0100

    chore: add support for Python 3.12 macOS arm64 wheels

For me, for instance, you should have set your email better. Now you will go down in the history as "random number @ noreply" 馃槢

@dvarrazzo
Copy link
Member

By the way, just to make it clear: I am very grateful for your contribution and should you contribute more in the future I will try to remember the workflow of force-pushing and merging rather than cherry-picking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants