Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional navigation keys for select/multiselect #561

Closed
wants to merge 1 commit into from
Closed

Add additional navigation keys for select/multiselect #561

wants to merge 1 commit into from

Conversation

hpcsc
Copy link
Contributor

@hpcsc hpcsc commented Aug 26, 2023

Description

This PR adds additional key binding Ctrl-p/Ctrl-n to move up and down in select/multiselect since these keys are quite commonly used

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #561 (3c7552d) into master (a6d54ab) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #561   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files          31       31           
  Lines        3574     3574           
=======================================
  Hits         2888     2888           
  Misses        629      629           
  Partials       57       57           
Files Changed Coverage Δ
interactive_multiselect_printer.go 56.22% <ø> (ø)
interactive_select_printer.go 53.08% <ø> (ø)

@hpcsc hpcsc closed this Sep 13, 2023
@hpcsc hpcsc deleted the additional-select-navigation-keys branch September 13, 2023 01:13
@MarvinJWendt
Copy link
Member

Hi @hpcsc, is there a specific reason that you closed your PR?

@hpcsc
Copy link
Contributor Author

hpcsc commented Sep 15, 2023

Hi @hpcsc, is there a specific reason that you closed your PR?

I was considering TUI libraries for my little tool. If this PR was merged, it would affect my choice.
In the end I went with https://github.com/charmbracelet/bubbletea because it allows me to customise the keys out of the box

If you feel this can be useful, I can re-open/re-create it

@MarvinJWendt
Copy link
Member

MarvinJWendt commented Sep 15, 2023

Feel free to re-open it :)

I am currently the only maintainer at @pterm, so things might take a little (as I also have several other open-source projects).
I generally liked the feature, just didn't have time to respond yet - sorry for the inconvenience.

@hpcsc
Copy link
Contributor Author

hpcsc commented Sep 15, 2023

Feel free to re-open it :)

I am currently the only maintainer at @pterm, so things might take a little (as I also have several other open-source projects). I generally liked the feature, just didn't have time to respond yet - sorry for the inconvenience.

completely understand. I really like this library too, quite intuitive to use
I have recreated this PR in #572 since re-open seems not possible at the moment

@MarvinJWendt
Copy link
Member

quite intuitive to use

That's the goal! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants