Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Invariant Violation: Maximum update depth exceeded..." bug #1049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elkinjosetm
Copy link

This PR fixes the condition used in the componentDidMount of the ScrollableTabView component that was causing infinite updates

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also facing an issue which can be resolved by this PR, can we get some merge this.

@tientruongvan1995
Copy link

you guys should merge this, the issue is so serious and thanks God it works effectively

@paldepind
Copy link

We experience this bug as well and can confirm that this PR fixes the issue.

@gevgasparyan
Copy link

I have the same issue

@harjot-sdaw
Copy link

Please merge this!!

@Balasnest
Copy link

Balasnest commented Oct 7, 2020

where is the fix? In which version?

Looks like its not yet merged. Please merge this asap. Its BREAKING in react-native > 0.60

quick fix: "react-native-scrollable-tab-view": "git+https://github.com/brentvatne/react-native-scrollable-tab-view#f3169cd",

ALiaoo added a commit to ALiaoo/react-native-scrollable-tab-view that referenced this pull request May 11, 2021
Fix "Invariant Violation: Maximum update depth exceeded..." bug ptomasroos#1049【ScrollableTabView设置了 page={activeTab}报的错】
groteworld added a commit to Metaformers/react-native-scrollable-tab-view that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants