Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoconf: fix references to external rules #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pchaigno
Copy link

@pchaigno pchaigno commented Nov 7, 2019

While trying to use the Autoconf grammar in Linguist (turns out we can't use it after all since it's GPL v3), our compiler detected that some of the includes have broken references to external rules. This pull request fixes it.

@ptomato
Copy link
Owner

ptomato commented Nov 8, 2019

Thanks for the contribution! I'm a bit mystified though, you are correct that the current references are broken, I see a lot of errors in the Sublime Text console like this:

Error loading scope:source.shell.comment: Unable to find syntax file for scope source.shell.comment in Packages/Autotools/Autoconf.tmLanguage
Error loading scope:source.shell.case-clause: Unable to find syntax file for scope source.shell.case-clause in Packages/Autotools/Autoconf.tmLanguage

However, the change in this pull request seems not to work correctly either, but in a different way:

no such context scope:source.shell#comment in Packages/Autotools/Autoconf.tmLanguage
no such context scope:source.shell#case-clause in Packages/Autotools/Autoconf.tmLanguage

Do you know why this might be happening?

@pchaigno
Copy link
Author

pchaigno commented Nov 8, 2019

I'm guessing this is happening because no grammar with the scope source.shell has been imported in the environment where you're loading the present grammar. Or that grammar doesn't have rules comment and case-clause.

/cc @Alhadis might know more.

@Alhadis
Copy link

Alhadis commented Nov 9, 2019

@ptomato It sounds like you're attempting to reference another grammar's rule which doesn't exist. Check the source.shell grammar and verify the repository object defines the keys comment and case-clause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants