Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DerivationTree.packages() -> HashSet<&P> #219

Merged
merged 3 commits into from May 10, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented May 7, 2024

In uv, we check the available versions to determine if there a prerelease versions and show an appropriate hint if required, mainly collecting package versions here to display a hint here.

This is the most efficient way of writing this function, but the derivation tree is small in the number of packages involved.

@konstin konstin added the enhancement New feature or request label May 7, 2024
Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a useful thing to have. It should probably have some tests. Separately it seems similar to code in errors_the_same_with_only_report_dependencies, perhaps this method could be used there.

src/report.rs Outdated Show resolved Hide resolved
src/report.rs Show resolved Hide resolved
@konstin
Copy link
Member Author

konstin commented May 10, 2024

I added .packages() to the existing error test case to avoid duplicating the setup code, let me know if there's a better place for it.

@Eh2406 Eh2406 added this pull request to the merge queue May 10, 2024
Merged via the queue into pubgrub-rs:dev with commit 89f9dff May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants