Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5544 vorschlag zur verbesserung der css wartbarkeit #5589

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Nov 14, 2023

No description provided.

…chlag-zur-verbesserung-der-css-wartbarkeit

* 'develop' of github.com:public-ui/kolibri: (25 commits)
  build(deps): bump chromedriver from 118.0.1 to 119.0.1
  v2.0.0-rc.9
  chore: remove popover snapshot test
  restore accordion expert slot
  Merge branch 'develop' of github.com:public-ui/kolibri into 5508-feature-toastservice-callback-zum-schließen-der-toasts-benötigt
  chore: update snapshots
  chore: remove postinstall for build all packages
  chore: handle snapshot tests
  chore: pnpm i builds all packages too
  Satisy ESLint rules
  chore: update snapshot
  revert
  reverted pnpm-lock.yaml
  update snapshots
  chore: update snaps
  fix font-family handling
  Rename kol-popover to kol-popover-wc and remove public API + react samples
  Extract and refactor alignFloatingElements method
  Bring back purple
  Fix badge examples to ensure minimum color contrast
  ...
…chlag-zur-verbesserung-der-css-wartbarkeit

* 'develop' of github.com:public-ui/kolibri:
  Update remaining snapshots
  Update snapshots
  Update enabled/disabled test-scripts
  Disable snapshot testing auto-focus
  Create codeql.yml
  Details: Move animation from entire details to container to just the content wrapper. This allows overflowing content (e.g. an outline) on the summary element.
@sdvg sdvg linked an issue Nov 14, 2023 that may be closed by this pull request
@@ -9,4 +11,16 @@ export default defineBuildConfig({
emitCJS: true,
inlineDependencies: true,
},
hooks: {
Copy link
Member Author

@sdvg sdvg Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diese Konfigurationsanpassung ist nicht notwendig, wenn wir nur Sass verwenden.
Ich habe sie für den Moment drin gelassen, damit die .css-Imports weiter funktionieren.

@sdvg
Copy link
Member Author

sdvg commented Nov 14, 2023

Das BEM-Beispiel ist mit Sass in mixins.scss umgesetzt und zeigt exemplarisch, wie Styles für Inputs strukturiert und wiederverwendet werden könnten.

@deleonio
Copy link
Contributor

deleonio commented Feb 1, 2024

Es gibt eine Lib für BAM: https://github.com/frontendr/bemmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Vorschlag zur Verbesserung der CSS Wartbarkeit
2 participants