Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed textarea scrollbar issue #6306

Merged
merged 8 commits into from
May 28, 2024
Merged

Conversation

Schollkolade
Copy link
Contributor

@Schollkolade Schollkolade commented Apr 15, 2024

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Pull request is linked to a problem
  • All changes relate to the problem
  • A11y tests performed successfully or not relevant
  • Manual test performed successfully (by reviewer) or not relevant

@Schollkolade Schollkolade linked an issue Apr 15, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Apr 15, 2024

deleonio
deleonio previously approved these changes Apr 16, 2024
packages/components/src/components/textarea/component.tsx Outdated Show resolved Hide resolved
@Schollkolade Schollkolade marked this pull request as ready for review April 17, 2024 13:28
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die Screenshots für Textarea Rows = 1 müssen genauso hoch bleiben, wie ein TextInput. Dazu müssen wir das Problem der Änderung im CSS analysieren.

@sdvg
Copy link
Member

sdvg commented Apr 18, 2024

Die Screenshots für Textarea Rows = 1 müssen genauso hoch bleiben, wie ein TextInput. Dazu müssen wir das Problem der Änderung im CSS analysieren.

Aktuell ist keine Höhe definiert, weder über CSS noch über ein rows-Attribut. Daher wird die Höhe gerade standardmäßig auf "zwei Zeilen" gesetzt, was die Änderung zur vorherigen Implementierung zur Folge hat.

Wenn der Standard "eine Zeile" sein soll, könnte die einfachste Lösung sein, die rows auf 1 zu setzen, so lange nicht anders definiert ist:

if (this._adjustHeight === true && this.ref /* SSR instanceof HTMLTextAreaElement */) {
	this._rows = this.state?._rows && this.state._rows > increaseTextareaHeight(this.ref) ? this.state._rows : increaseTextareaHeight(this.ref);
-}
+} else if (!this._rows) {
+	this._rows = 1;
+}```

@deleonio deleonio force-pushed the develop branch 2 times, most recently from 487bb0f to f56f225 Compare May 14, 2024 02:40
…147-fix-textarea-scrollbar

* 'develop' of github.com:public-ui/kolibri: (82 commits)
  fix: format
  Refs: #6390
  Input File: Add files list as value to input and change events
  Rename component files to align with shadow settings
  Adjust themes for new table structure
  Change usage in TableStateful from TableStateless to TableStatelessWc and extract table stateless styles into mixin
  (#6302) Bugfix table sorting button style
  (#6302) Bugfix table sorting button style
  Fix exception that occurred when rendering with no data
  Fix random lint error
  Remove debug code
  Manage render keys for table data
  (#6183) Bugfix radio button option listener
  Fix path to types for themes package
  fix format
  Fix nav Test
  Update all snapshots$ $ Refs: #6284
  Fix type for table selection label function argument
  Update button.scss
  Refactor OptionalProps in split-button
  ...
@deleonio deleonio merged commit a5c4cad into develop May 28, 2024
5 checks passed
@deleonio deleonio deleted the feature/6147-fix-textarea-scrollbar branch May 28, 2024 08:57
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: 🔍 Review
Development

Successfully merging this pull request may close these issues.

🐞 Bug: Textarea zeigt keinen Scollbar
4 participants