-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed textarea scrollbar issue #6306
Conversation
Netlify Draft Deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Die Screenshots für Textarea Rows = 1 müssen genauso hoch bleiben, wie ein TextInput. Dazu müssen wir das Problem der Änderung im CSS analysieren.
Aktuell ist keine Höhe definiert, weder über CSS noch über ein Wenn der Standard "eine Zeile" sein soll, könnte die einfachste Lösung sein, die if (this._adjustHeight === true && this.ref /* SSR instanceof HTMLTextAreaElement */) {
this._rows = this.state?._rows && this.state._rows > increaseTextareaHeight(this.ref) ? this.state._rows : increaseTextareaHeight(this.ref);
-}
+} else if (!this._rows) {
+ this._rows = 1;
+}``` |
…com/public-ui/kolibri into feature/6147-fix-textarea-scrollbar
$ Refs: #6147
487bb0f
to
f56f225
Compare
…147-fix-textarea-scrollbar * 'develop' of github.com:public-ui/kolibri: (82 commits) fix: format Refs: #6390 Input File: Add files list as value to input and change events Rename component files to align with shadow settings Adjust themes for new table structure Change usage in TableStateful from TableStateless to TableStatelessWc and extract table stateless styles into mixin (#6302) Bugfix table sorting button style (#6302) Bugfix table sorting button style Fix exception that occurred when rendering with no data Fix random lint error Remove debug code Manage render keys for table data (#6183) Bugfix radio button option listener Fix path to types for themes package fix format Fix nav Test Update all snapshots$ $ Refs: #6284 Fix type for table selection label function argument Update button.scss Refactor OptionalProps in split-button ...
☑️ Definition of Done checklist